*: use origin-v4.0:kube-client-agent #538

hexfusion · 2019-03-11T16:11:45Z

This PR adds the newly built kube-client-agent image registry.svc.ci.openshift.org/openshift/origin-v4.0:kube-client-agent replacing the coreos/kubecsr upstream.

Because of chicken and egg I need to set the default to pass tests and will update this after the flag is added to installer.

hexfusion · 2019-03-11T16:30:24Z

updating test yamls

hexfusion · 2019-03-11T16:48:33Z

/test images

kikisdeliveryservice · 2019-03-11T18:06:55Z

hi @hexfusion !

Could you update the commit message to include (in the body): after related flag PR merged into installer, uncomment bootstrapCmd.MarkFlagRequired("kube-client-agent-image") in bootstrap.go

hexfusion · 2019-03-11T18:24:23Z

@kikisdeliveryservice sure thing all set.

kikisdeliveryservice · 2019-03-11T18:33:37Z

thanks @hexfusion !!

hexfusion · 2019-03-13T15:04:40Z

/retest

hexfusion · 2019-03-13T16:49:04Z

/test images

hexfusion · 2019-03-13T17:02:30Z

/test images

hexfusion · 2019-03-13T17:08:18Z

/retest

hexfusion · 2019-03-14T15:54:29Z

/retest

hexfusion · 2019-03-14T17:34:18Z

removing default for testing release.

cgwalters · 2019-03-14T17:50:22Z

Oh man this again...luckily the scars are fresh from the last time:
#471

It looks like you probably saw #471 (comment) at least?

hexfusion · 2019-03-14T18:16:51Z

@cgwalters @abhinavdahiya with the above PR and installer with openshift/installer#1401 it works can we force 1401? then this?

To confirm my test actions I did the following which was the latest ci release on this PR. My installer as noted contains openshift/installer#1401

OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE=registry.svc.ci.openshift.org/ci-op-gmkb8pn6/release:latest openshift-install-dev --log-level debug --dir aws-cluster/cluster-dev create cluster

abhinavdahiya · 2019-03-14T18:28:03Z

@cgwalters @abhinavdahiya with the above PR and installer with openshift/installer#1401 it works can we force 1401? then this?

To confirm my test actions I did the following which was the latest ci release on this PR. My installer as noted contains openshift/installer#1401
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE=registry.svc.ci.openshift.org/ci-op-gmkb8pn6/release:latest openshift-install-dev --log-level debug --dir aws-cluster/cluster-dev create cluster

The way you can proceed without force is:

in This PR

hard code the image to registry one here, do not use the one set by flag.
hard code the image to registry one here, do not use the one set in config map.

This allows installer PR Bug 1684670: data/data/bootstrap: add kube-client-agent-image flag installer#1401 to set set the flag,
come and switch here and here to use the correct images from flag and config map. And also set the flag as required.

This way the images always stay the same.

hexfusion · 2019-03-14T20:55:11Z

Ci failure unrelated I just ran OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE=registry.svc.ci.openshift.org/ci-op-0xsz8z88/release:latest with success.

level=error msg="Error: Error applying plan:"
level=error
level=error msg="4 errors occurred:"
level=error msg="\t* module.vpc.aws_route_table_association.route_net[1]: 1 error occurred:"
level=error msg="\t* aws_route_table_association.route_net.1: timeout while waiting for state to become 'success' (timeout: 5m0s)"
level=error
level=error
level=error msg="\t* module.vpc.aws_route_table_association.route_net[0]: 1 error occurred:"
level=error msg="\t* aws_route_table_association.route_net.0: timeout while waiting for state to become 'success' (timeout: 5m0s)"
level=error
level=error
level=error msg="\t* module.vpc.aws_route_table_association.route_net[3]: 1 error occurred:"
level=error msg="\t* aws_route_table_association.route_net.3: timeout while waiting for state to become 'success' (timeout: 5m0s)"
level=error
level=error
level=error msg="\t* module.vpc.aws_route_table_association.route_net[4]: 1 error occurred:"
level=error msg="\t* aws_route_table_association.route_net.4: timeout while waiting for state to become 'success' (timeout: 5m0s)"
level=error

hexfusion · 2019-03-14T20:55:45Z

/retest

hexfusion · 2019-03-14T21:46:26Z

/test e2e-aws

hexfusion · 2019-03-14T21:48:05Z

@abhinavdahiya PTAL this will pass if we can leap over resource limit.

cmd/machine-config-operator/bootstrap.go

abhinavdahiya · 2019-03-14T22:09:53Z

@abhinavdahiya PTAL this will pass if we can leap over resource limit.

LGTM

- after related flag PR merged into installer, uncomment bootstrapCmd.MarkFlagRequired("kube-client-agent-image") in bootstrap.go Signed-off-by: Sam Batschelet <sbatsche@redhat.com>

hexfusion · 2019-03-14T23:43:03Z

/retest

hexfusion · 2019-03-15T00:29:13Z

/test e2e-aws

hexfusion · 2019-03-15T02:10:53Z

/cc @cgwalters @kikisdeliveryservice

runcom · 2019-03-15T13:07:37Z

/approve
/lgtm

openshift-ci-robot · 2019-03-15T13:07:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hexfusion · 2019-03-15T13:54:20Z

/test e2e-aws-op

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2019

openshift-ci-robot requested review from ashcrow and runcom March 11, 2019 16:12

hexfusion force-pushed the fx_kubecsr branch from 7ce8189 to b88fedb Compare March 11, 2019 16:36

hexfusion force-pushed the fx_kubecsr branch from b88fedb to 7fafc66 Compare March 11, 2019 18:23

hexfusion mentioned this pull request Mar 11, 2019

Bug 1684670: data/data/bootstrap: add kube-client-agent-image flag openshift/installer#1401

Merged

hexfusion force-pushed the fx_kubecsr branch 3 times, most recently from 70e063d to a10801b Compare March 11, 2019 21:26

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2019

hexfusion force-pushed the fx_kubecsr branch from a10801b to e39ec80 Compare March 13, 2019 13:02

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2019

hexfusion force-pushed the fx_kubecsr branch from e39ec80 to 947065d Compare March 13, 2019 14:09

hexfusion force-pushed the fx_kubecsr branch from 947065d to 60798c9 Compare March 13, 2019 21:46

hexfusion force-pushed the fx_kubecsr branch from 60798c9 to 696bc69 Compare March 14, 2019 17:33

hexfusion force-pushed the fx_kubecsr branch from 696bc69 to 4776c62 Compare March 14, 2019 19:49

hexfusion force-pushed the fx_kubecsr branch from 4776c62 to 909b4d1 Compare March 14, 2019 20:00

abhinavdahiya reviewed Mar 14, 2019

View reviewed changes

cmd/machine-config-operator/bootstrap.go Outdated Show resolved Hide resolved

abhinavdahiya reviewed Mar 14, 2019

View reviewed changes

cmd/machine-config-operator/bootstrap.go Outdated Show resolved Hide resolved

*: use origin-v4.0:kube-client-agent

b3d9240

- after related flag PR merged into installer, uncomment bootstrapCmd.MarkFlagRequired("kube-client-agent-image") in bootstrap.go Signed-off-by: Sam Batschelet <sbatsche@redhat.com>

hexfusion force-pushed the fx_kubecsr branch from 909b4d1 to b3d9240 Compare March 14, 2019 22:19

openshift-ci-robot requested review from cgwalters and kikisdeliveryservice March 15, 2019 02:10

openshift-ci-robot assigned runcom Mar 15, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019

openshift-merge-robot merged commit 8381bc2 into openshift:master Mar 15, 2019

hexfusion deleted the fx_kubecsr branch March 15, 2019 14:31

hexfusion mentioned this pull request Mar 15, 2019

*: set kube-client-agent-image flag as required #555

Merged

runcom mentioned this pull request Apr 12, 2019

Add etcd-quorum-guard manifests and doc #613

Closed

*: use origin-v4.0:kube-client-agent #538

*: use origin-v4.0:kube-client-agent #538

Uh oh!

Conversation

hexfusion commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hexfusion commented Mar 11, 2019

Uh oh!

hexfusion commented Mar 11, 2019

Uh oh!

kikisdeliveryservice commented Mar 11, 2019

Uh oh!

hexfusion commented Mar 11, 2019

Uh oh!

kikisdeliveryservice commented Mar 11, 2019

Uh oh!

hexfusion commented Mar 13, 2019

Uh oh!

hexfusion commented Mar 13, 2019

Uh oh!

hexfusion commented Mar 13, 2019

Uh oh!

hexfusion commented Mar 13, 2019

Uh oh!

hexfusion commented Mar 14, 2019

Uh oh!

hexfusion commented Mar 14, 2019

Uh oh!

cgwalters commented Mar 14, 2019

Uh oh!

hexfusion commented Mar 14, 2019

Uh oh!

abhinavdahiya commented Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hexfusion commented Mar 14, 2019

Uh oh!

hexfusion commented Mar 14, 2019

Uh oh!

hexfusion commented Mar 14, 2019

Uh oh!

hexfusion commented Mar 14, 2019

Uh oh!

Uh oh!

Uh oh!

abhinavdahiya commented Mar 14, 2019

Uh oh!

hexfusion commented Mar 14, 2019

Uh oh!

hexfusion commented Mar 15, 2019

Uh oh!

hexfusion commented Mar 15, 2019

Uh oh!

runcom commented Mar 15, 2019

Uh oh!

openshift-ci-robot commented Mar 15, 2019

Uh oh!

hexfusion commented Mar 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hexfusion commented Mar 11, 2019 •

edited

Loading

abhinavdahiya commented Mar 14, 2019 •

edited

Loading